Skip to content

refactor: use atcute oauth client#3009

Draft
ghostdevv wants to merge 7 commits into
mainfrom
w/atcute-oauth
Draft

refactor: use atcute oauth client#3009
ghostdevv wants to merge 7 commits into
mainfrom
w/atcute-oauth

Conversation

@ghostdevv

Copy link
Copy Markdown
Member

🔗 Linked issue

🧭 Context

Updating @atproto/oauth-client-node breaks stuff, so I thought instead of trying to figure that out we could switch fully to atcute libraries - this being the first step of that

📚 Description

@ghostdevv
ghostdevv requested a review from fatfingers23 July 5, 2026 23:06
@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Error Error Jul 24, 2026 2:54pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jul 24, 2026 2:54pm
npmx-lunaria Ignored Ignored Jul 24, 2026 2:54pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9a670cad-fdc7-4c8e-89ef-29ce8924b7a4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch w/atcute-oauth

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@socket-security

socket-security Bot commented Jul 5, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

e18e dependency analysis

No dependency warnings found.

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

@fatfingers23 fatfingers23 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Only thing I had to flag was migration of OAuth session store

async get(key: string): Promise<NodeSavedSession | undefined> {
let session = await this.cache.get<NodeSavedSession>(this.createStorageKey(key))
async get(key: string): Promise<StoredSession | undefined> {
const session = await this.cache.get<StoredSession>(this.createStorageKey(key))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the types the same here from @atproto to @ATCUTE? Do we want to do some kind of translate layer or just have everyone login again?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to make everyone login again xD the sessions are already pretty short, and it reduces the amount of complexity and code we have to remove later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants