refactor: use atcute oauth client#3009
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
e18e dependency analysisNo dependency warnings found. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
fatfingers23
left a comment
There was a problem hiding this comment.
Looks good to me! Only thing I had to flag was migration of OAuth session store
| async get(key: string): Promise<NodeSavedSession | undefined> { | ||
| let session = await this.cache.get<NodeSavedSession>(this.createStorageKey(key)) | ||
| async get(key: string): Promise<StoredSession | undefined> { | ||
| const session = await this.cache.get<StoredSession>(this.createStorageKey(key)) |
There was a problem hiding this comment.
I'm happy to make everyone login again xD the sessions are already pretty short, and it reduces the amount of complexity and code we have to remove later
🔗 Linked issue
🧭 Context
Updating
@atproto/oauth-client-nodebreaks stuff, so I thought instead of trying to figure that out we could switch fully to atcute libraries - this being the first step of that📚 Description