fix: license icon#2850
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughA new custom icons asset file is created with five icon definitions, integrated into the build sprite generation script and uno.config runtime configuration, and used to remap LICENSE files to display a custom license-minified icon instead of the standard vscode-icons version. ChangesCustom License Icon Support
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🔗 Linked issue
Resolves #2558
🧭 Context
Firefox has issues rendering SVG filters added from a sprite via "use"/ To solve this, I added a custom icon and support for them in sprite generation.
A similar style is used in the cursor and is generally closer to the other icons on the page, so I don't think anything will change for the user
Example page - https://npmxdev-git-fork-alexdln-fix-license-icon-npmx.vercel.app/package-code/@babel/helper-define-polyfill-provider/v/1.0.0-rc.2