Skip to content

fix: use owners.name facet for user profile pkgs #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
43081j merged 1 commit into from
Apr 14, 2026
+7 −7
Merged

fix: use owners.name facet for user profile pkgs #2513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/composables/npm/useAlgoliaSearch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ export function useAlgoliaSearch() {
}
}

/** Fetch all packages for an owner using `owner.name` filter with pagination. */
async function searchByOwner(
/** Fetch all packages for a maintainer using `owners.name` filter with pagination. */
async function searchByMaintainer(
ownerName: string,
options: { maxResults?: number } = {},
): Promise<NpmSearchResponse> {
Expand All @@ -185,7 +185,7 @@ export function useAlgoliaSearch() {
query: '',
offset,
length,
filters: `owner.name:${ownerName}`,
filters: `owners.name:${ownerName}`,
analyticsTags: ['npmx.dev'],
attributesToRetrieve: ATTRIBUTES_TO_RETRIEVE,
attributesToHighlight: [],
Expand Down Expand Up @@ -286,7 +286,7 @@ export function useAlgoliaSearch() {
requests.push({
indexName,
query: '',
filters: `owner.name:${checks.name}`,
filters: `owners.name:${checks.name}`,
length: 1,
analyticsTags: ['npmx.dev'],
attributesToRetrieve: EXISTENCE_CHECK_ATTRS,
Expand Down Expand Up @@ -347,7 +347,7 @@ export function useAlgoliaSearch() {
return {
search,
searchWithSuggestions,
searchByOwner,
searchByMaintainer,
getPackagesByName,
}
}
4 changes: 2 additions & 2 deletions app/composables/npm/useUserPackages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function useUserPackages(username: MaybeRefOrGetter<string>) {
})
// this is only used in npm path, but we need to extract it when the composable runs
const { $npmRegistry } = useNuxtApp()
const { searchByOwner } = useAlgoliaSearch()
const { searchByMaintainer } = useAlgoliaSearch()

// --- Incremental loading state (npm path) ---
const currentPage = shallowRef(1)
Expand Down Expand Up @@ -58,7 +58,7 @@ export function useUserPackages(username: MaybeRefOrGetter<string>) {
// --- Algolia: fetch all at once ---
if (provider === 'algolia') {
try {
const response = await searchByOwner(user)
const response = await searchByMaintainer(user)

// Guard against stale response (user/provider changed during await)
if (user !== toValue(username) || provider !== searchProviderValue.value) {
Expand Down
Loading