Skip to content

fix: avoid showing "No README is available" during README load #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akadotsh wants to merge 4 commits into
base: main
Choose a base branch
from
+20 −3
Open

fix: avoid showing "No README is available" during README load #2473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
752f8f7
fix: avoid showing "No README is available" while README is loading
akadotsh Apr 11, 2026
8bca677
fix(package-readme): avoid premature empty state and add loading/erro…
akadotsh Apr 13, 2026
8133aa6
chore(i18n): update schema for readme error_loading key
akadotsh Apr 13, 2026
c33aee2
fix(readme): add loading/error states and clean up i18n
akadotsh Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions app/pages/package/[[org]]/[name].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ if (import.meta.server) {
}

// Fetch README for specific version if requested, otherwise latest
const { data: readmeData } = useLazyFetch<ReadmeResponse>(
const { data: readmeData, status: readmeStatus } = useLazyFetch<ReadmeResponse>(
() => {
const base = `/api/registry/readme/${packageName.value}`
const version = resolvedVersion.value
Expand Down Expand Up @@ -1040,7 +1040,20 @@ const showSkeleton = shallowRef(false)

<!-- eslint-disable vue/no-v-html -- HTML is sanitized server-side -->
<Readme v-if="readmeData?.html" :html="readmeData.html" />
<p v-else class="text-fg-muted italic">
<p
v-else-if="readmeStatus === 'pending'"
class="flex items-center gap-2 text-fg-subtle italic"
>
<span class="i-svg-spinners:ring-resize w-4 h-4" aria-hidden="true" />
<span>{{ $t('common.loading') }}…</span>
</p>
<p v-else-if="readmeStatus === 'error'" class="text-fg-muted italic">
{{ $t('package.readme.error_loading') }}
</p>
<p
v-else-if="readmeStatus === 'success' && !readmeData?.html"
class="text-fg-muted italic"
>
{{ $t('package.readme.no_readme') }}
<a
v-if="repositoryUrl"
Expand Down
3 changes: 2 additions & 1 deletion i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,8 @@
"warning": "Warning",
"caution": "Caution"
},
"copy_as_markdown": "Copy README as Markdown"
"copy_as_markdown": "Copy README as Markdown",
"error_loading": "Failed to load README details"
},
"provenance_section": {
"title": "Provenance",
Expand Down
3 changes: 3 additions & 0 deletions i18n/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1446,6 +1446,9 @@
},
"copy_as_markdown": {
"type": "string"
},
"error_loading": {
"type": "string"
}
},
"additionalProperties": false
Expand Down
Loading