Skip to content

fix: don't export CollectorChecker#1467

Merged
wojtekmaj merged 1 commit intonpmx-dev:mainfrom
wojtekmaj:dont-export-types
Feb 13, 2026
Merged

fix: don't export CollectorChecker#1467
wojtekmaj merged 1 commit intonpmx-dev:mainfrom
wojtekmaj:dont-export-types

Conversation

@wojtekmaj
Copy link
Contributor

Copilot AI review requested due to automatic review settings February 13, 2026 13:08
@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 13, 2026 1:10pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 13, 2026 1:10pm
npmx-lunaria Ignored Ignored Feb 13, 2026 1:10pm

Request Review

@wojtekmaj wojtekmaj changed the title Don't export CollectorChecker fix: don't export CollectorChecker Feb 13, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unnecessary exports of the CollectorChecker type from two UnoCSS preset files. The type was previously exported but never imported anywhere in the codebase, causing Knip's end-to-end tests to fail. The type is only used internally as a parameter type for the exported preset functions.

Changes:

  • Removed export keyword from CollectorChecker type in uno-preset-rtl.ts
  • Removed export keyword from CollectorChecker type in uno-preset-a11y.ts

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
uno-preset-rtl.ts Converted CollectorChecker from exported type to internal type, as it's only used as a parameter type and never imported externally
uno-preset-a11y.ts Converted CollectorChecker from exported type to internal type, as it's only used as a parameter type and never imported externally

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

📝 Walkthrough

Walkthrough

The pull request removes the export keyword from the CollectorChecker type definition in two files: uno-preset-a11y.ts and uno-preset-rtl.ts. This changes the type from being publicly exported to internal module scope. The type signature itself remains unchanged—it continues to define a function type accepting a warning string and rule string parameter. These are visibility-only modifications with no impact on runtime behaviour or internal usage.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description references a specific issue with Knip E2E tests and provides a direct link to the failing run, which relates to the changeset of removing CollectorChecker exports.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@wojtekmaj wojtekmaj enabled auto-merge February 13, 2026 13:59
@wojtekmaj wojtekmaj added this pull request to the merge queue Feb 13, 2026
Merged via the queue into npmx-dev:main with commit 5ffed03 Feb 13, 2026
23 of 24 checks passed
@wojtekmaj wojtekmaj deleted the dont-export-types branch February 13, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants