fix: don't export CollectorChecker#1467
Conversation
Legit issue that causes Knip E2Es to fail :) https://github.com/webpro-nl/knip/actions/runs/21980071806/job/63500314522
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
There was a problem hiding this comment.
Pull request overview
This PR removes unnecessary exports of the CollectorChecker type from two UnoCSS preset files. The type was previously exported but never imported anywhere in the codebase, causing Knip's end-to-end tests to fail. The type is only used internally as a parameter type for the exported preset functions.
Changes:
- Removed
exportkeyword fromCollectorCheckertype inuno-preset-rtl.ts - Removed
exportkeyword fromCollectorCheckertype inuno-preset-a11y.ts
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| uno-preset-rtl.ts | Converted CollectorChecker from exported type to internal type, as it's only used as a parameter type and never imported externally |
| uno-preset-a11y.ts | Converted CollectorChecker from exported type to internal type, as it's only used as a parameter type and never imported externally |
📝 WalkthroughWalkthroughThe pull request removes the 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Legit issue that causes Knip E2Es to fail :)
https://github.com/webpro-nl/knip/actions/runs/21980071806/job/63500314522