Skip to content

Conversation

@TheAlexLichter
Copy link
Contributor

The aria-label is invalid on a <div> element. I seized the opportunity and used semantic html (ul + li) to describe the keyword list better, which also permits the aria-label attribute.

@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 12, 2026 1:49am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 12, 2026 1:49am
npmx-lunaria Ignored Ignored Feb 12, 2026 1:49am

Request Review

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Package/Card.vue 60.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

This pull request converts the keywords container in app/components/Package/Card.vue from a div to a semantic ul with role="list". Each keyword is now wrapped in an li that contains the existing ButtonBase, preserving click behaviour and aria-pressed logic. The "+N" overflow indicator is moved into its own li. Conditional rendering and titles remain unchanged. No exported or public declarations were modified.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset, explaining the accessibility fix by replacing a div with semantic HTML (ul + li) for the keyword list.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

@TheAlexLichter TheAlexLichter force-pushed the fix/a11y-invalid-aria-label branch from 4e9bc1c to f8267f2 Compare February 11, 2026 23:32
@knowler knowler added the a11y Related to accessibility and inclusion label Feb 12, 2026
Copy link
Contributor

@knowler knowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@knowler knowler added this pull request to the merge queue Feb 12, 2026
Merged via the queue into npmx-dev:main with commit 7125e50 Feb 12, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Related to accessibility and inclusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants