Skip to content

fix: remove duplicate css classes#1400

Merged
serhalp merged 2 commits intonpmx-dev:mainfrom
TheAlexLichter:fix/duplicate-css-classes
Feb 12, 2026
Merged

fix: remove duplicate css classes#1400
serhalp merged 2 commits intonpmx-dev:mainfrom
TheAlexLichter:fix/duplicate-css-classes

Conversation

@TheAlexLichter
Copy link
Contributor

All removed CSS classes are already part of the underlying components, causing HTML validator issues due to being duplicates when rendered.

@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 11, 2026 11:14pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 11, 2026 11:14pm
npmx-lunaria Ignored Ignored Feb 11, 2026 11:14pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

This pull request makes styling-only changes across four Vue components: it removes the font-mono utility from the maintainer name link in Maintainers.vue, removes a hover:text-fg hover class from a button in ManagerSelect.vue, simplifies ButtonBase classes (removing inline-flex, justify-center, duration-200) in Versions.vue, and simplifies button classes and removes a selected-state border in Compare/FacetSelector.vue. No logic, data flow, or public API signatures were changed.

Possibly related PRs

Suggested labels

front

Suggested reviewers

  • alexdln
  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains that removed CSS classes are duplicates already present in underlying components, directly relating to the changeset across all four Vue files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

:aria-pressed="isFacetSelected(facet.id)"
:aria-label="facet.label"
class="inline-flex items-center gap-1 px-1.5 py-0.5 font-mono text-xs rounded border transition-colors duration-200 focus-visible:outline-accent/70"
class="gap-1 px-1.5 rounded transition-colors focus-visible:outline-accent/70"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove focus-visible:outline-accent/70 — focus styling is applied globally for buttons.

The inline focus-visible:outline-accent/70 utility class contradicts the project's convention. Focus-visible styling for <button> elements is already handled globally via main.css, so this class is unnecessary and may cause inconsistent focus states.

🔧 Suggested fix
-          class="gap-1 px-1.5 rounded transition-colors focus-visible:outline-accent/70"
+          class="gap-1 px-1.5 rounded transition-colors"

Based on learnings: "In the npmx.dev project, focus-visible styling for buttons and selects is applied globally via main.css... individual buttons or selects in Vue components should not rely on inline focus-visible utility classes like focus-visible:outline-accent/70."

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
class="gap-1 px-1.5 rounded transition-colors focus-visible:outline-accent/70"
class="gap-1 px-1.5 rounded transition-colors"

Copy link
Contributor

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've been seeing these warnings locally too :)

@serhalp serhalp added this pull request to the merge queue Feb 12, 2026
Merged via the queue into npmx-dev:main with commit d8e9a4e Feb 12, 2026
17 checks passed
@TheAlexLichter TheAlexLichter deleted the fix/duplicate-css-classes branch February 12, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants