Skip to content

Conversation

@rzzf
Copy link
Contributor

@rzzf rzzf commented Feb 11, 2026

The search input in Filters cannot accept any input.
https://npmx.dev/org/vue

@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 11, 2026 9:02am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 11, 2026 9:02am
npmx-lunaria Ignored Ignored Feb 11, 2026 9:02am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

The changes refactor the filter text input binding in the Filter Panel component. A new computed property filterText was introduced to establish two-way data binding with the filter text value. The component binding was updated from a unidirectional :value assignment to use v-model with the new computed property. The explicit handleTextInput event handler was removed in favour of the computed property's setter to emit text update events. This simplifies the data flow for managing the filter text input within the InputBase component.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly addresses the changeset, identifying a specific bug (search input cannot accept input) with a reproducible URL and explaining the fix applied.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Filter/Panel.vue 25.00% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Comment on lines +35 to +38
const filterText = computed({
get: () => props.filters.text,
set: value => emit('update:text', value),
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use a defineModel('text') instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property comes from props.filters.text, so is defineModel('text') unnecessary?
If so, ListToolbar.vue would also need to be updated accordingly.

Referenced from

const filterValue = computed({
get: () => props.filter,
set: value => emit('update:filter', value),
})

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, I see.

yes, this is awkward prop drilling we need to fix at some point but not in this PR

@danielroe danielroe added this pull request to the merge queue Feb 11, 2026
Merged via the queue into npmx-dev:main with commit a331176 Feb 11, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants