-
-
Notifications
You must be signed in to change notification settings - Fork 238
fix: filter search cannot be typed #1376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThe changes refactor the filter text input binding in the Filter Panel component. A new computed property 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| const filterText = computed({ | ||
| get: () => props.filters.text, | ||
| set: value => emit('update:text', value), | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use a defineModel('text') instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property comes from props.filters.text, so is defineModel('text') unnecessary?
If so, ListToolbar.vue would also need to be updated accordingly.
Referenced from
npmx.dev/app/components/Package/ListControls.vue
Lines 22 to 25 in 9aae078
| const filterValue = computed({ | |
| get: () => props.filter, | |
| set: value => emit('update:filter', value), | |
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh, I see.
yes, this is awkward prop drilling we need to fix at some point but not in this PR
The search input in Filters cannot accept any input.
https://npmx.dev/org/vue