fix(arborist): contain lockfile patch path in reify applyPatch - #9886
Open
ubeddulla wants to merge 1 commit into
Open
fix(arborist): contain lockfile patch path in reify applyPatch#9886ubeddulla wants to merge 1 commit into
ubeddulla wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reify's #applyPatch reads node.patched.path with resolve(this.path, patchPath) but only re-checks integrity, not that the path stays inside the project. node.patched is loaded verbatim from package-lock.json (load-virtual sets patched: sw.patched), and when reify runs on a pre-built ideal tree from loadVirtual the buildIdealTree short-circuit skips resolvePatchedDependencies, so a crafted lockfile path like ../../escape.patch reaches this readFile and is read from outside the project root. The sibling patched-dependencies.js readPatch already guards this exact value; #applyPatch's own comment says it re-validates here too but only checks integrity. Add the same relative/startsWith('..')/isAbsolute containment check before the read so an out-of-project patch path throws EPATCHUNSAFE, with a regression test that drives the lockfile-sourced flow.