fix(arborist): reject uninstall args that carry a version - #9881
Open
lazerg wants to merge 3 commits into
Open
Conversation
lazerg
force-pushed
the
fix/9880-uninstall-version-spec
branch
from
August 16, 2026 07:39
7699913 to
a159748
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
npm uninstall vite@8.2.1neither removes the package nor complains about the argument. The spec goes straight through to Arborist as anrmentry, nothing in the tree is namedvite@8.2.1, so the reify finishes with "up to date" andnpm lsstill showsvite.npm updatealready validates its own argument list and throwsEUPDATEARGSfor anything that is not a bare package name. This applies the same rule torm, so a version, tag or range now fails withERMARGSand the message names the command to run instead.Testing
New case in
workspaces/arborist/test/arborist/build-ideal-tree.js, next to the existing rm test and mirroring the update one. It covers an exact version, a tag, ranges, a scoped name carrying a version, and a filesystem path, where the suggestion falls back to<pkg>because there is no name to print. It fails without the change.References
Fixes #9880