fix(config): pause progress spinner during interactive editor spawn#9372
Open
Zelys-DFKH wants to merge 1 commit into
Open
fix(config): pause progress spinner during interactive editor spawn#9372Zelys-DFKH wants to merge 1 commit into
Zelys-DFKH wants to merge 1 commit into
Conversation
When npm config edit or npm edit opens an interactive editor, the progress spinner kept running and wrote ANSI control codes into the editor buffer, corrupting the display. Both commands now call input.start() before opening the editor, which pauses the display layer while the editor has control of the terminal. Closes npm#9142, Closes npm#9184. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9142, Fixes #9184
When `npm config edit` or `npm edit` opens an interactive editor, the progress spinner keeps running and writes ANSI control codes into the buffer, garbling the display. Neither command called `input.start()` before opening the editor, though `help.js` and `open-url.js` already handle this correctly. Wrapping both editor spawns in `input.start()` lets the spinner step aside while the editor has control of the terminal, and closes both issues at once.