Conversation
…me existing commands missing docs
owlstronaut
approved these changes
Jan 6, 2026
Contributor
owlstronaut
left a comment
owlstronaut
left a comment
There was a problem hiding this comment.
This looks great to me
Comment on lines
+238
to
+239
| // this needs to be rest after because some commands run | ||
| // this.npm.config.checkUnknown('publishConfig', key) |
Contributor
There was a problem hiding this comment.
Suggested change
| // this needs to be rest after because some commands run | |
| // this.npm.config.checkUnknown('publishConfig', key) | |
| // this needs to be reset after because some commands run `this.npm.config.checkUnknown('publishConfig', key)` |
Comment on lines
+40
to
+41
| #argv = undefined | ||
| #excludeNpmCwd = undefined |
Contributor
There was a problem hiding this comment.
Are these used somewhere?
Contributor
|
just to clarify with this new PR - does this PR include a way for users to specify per-command configs? If not, how would a user override any built-in per-command configuration? |
Contributor
Author
no
new command definitions are flag-only for now on a case by case basis we could have prefixed long globals exist |
Contributor
Author
|
drafting this PR because this has some issues i've fixed them locally and am working them out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternate version of #8776
npm cli config changes
--init-authorwarnings, recent versions of npm warn when an unknown config value is used in any source. The issue being that we need to process the argv positional to route the command and get the command-level-config, and notlog.warnon that first pass...Original Solution
flagssourceinifiles always get loaded into config (even if they're not in definitions)New Plan
BaseCommandwe have aflagsmethod that usesnopton the command definitions and simply returns the value..execcan just callthis.flags()and get command level flags.