fix: Lazy load country polygons to prevent UI freeze (#1056)#1188
Merged
Conversation
Fix #1056: Web freezing when loading locality map. The countryPolygons.ts file is 4.4MB and was being imported synchronously, causing the main thread to block and the UI to freeze. Solution: - Dynamically import countryPolygons using async import() - Only load the data after the map component mounts - Add loading state for country borders This prevents the large module from blocking the main thread during initial page load. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
Collaborator
Author
|
@copilot Please review this pull request. |
Contributor
Collaborator
Author
|
@copilot Please review this pull request. |
Contributor
Reviewed the current PR changes. I don’t see additional code changes needed at this point. I also re-ran validation locally ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1056: Web freezing when loading locality map.
Root Cause:
The countryPolygons.ts module is 4.4MB and was being imported synchronously, blocking the main thread and causing UI freezes.
Solution:
Impact:
Testing: