Skip to content

fix: keep modals above the global findings banner - #50

Closed
damusix wants to merge 1 commit into
mainfrom
fix/modal-above-global-banner
Closed

damusix wants to merge 1 commit into
mainfrom
fix/modal-above-global-banner

Conversation

@damusix

@damusix damusix commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

When a model has global findings, the fixed banner (z-index 200) sat above modals (100), so on short viewports it covered a tall modal's close button. CI on main now fails test-graph-bundle-mode on this (re-ran main's last green run on the current runner: Bun 1.4.2, Linux).

  • Modal backdrops move to 210 (stacked 220), still below the flow edge tooltip (9999).
  • The JSON value dialog is portaled to document.body: the Dictionary view is its own stacking context and trapped the dialog under the banner.

test-modal-above-banner.ts covers the entity modal, a Dictionary JSON dialog, and stacked backdrop clicks; it fails without either change. Unblocks #49.

@damusix

damusix commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

Folded into #49 (one task, one PR); the banner fix is what unblocks #49's CI.

@damusix damusix closed this Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant