Skip to content

Realign code import ownership surface#412

Merged
djm81 merged 3 commits intodevfrom
bugfix/module-migration-11-project-codebase-ownership-realignment
Mar 12, 2026
Merged

Realign code import ownership surface#412
djm81 merged 3 commits intodevfrom
bugfix/module-migration-11-project-codebase-ownership-realignment

Conversation

@djm81
Copy link
Collaborator

@djm81 djm81 commented Mar 11, 2026

Description

Realigns brownfield import ownership so the canonical public path is specfact code import, with project narrowed to project-bundle lifecycle behavior. This also updates the OpenSpec change artifacts, command audit/runtime validation, and release-facing docs/prompts to the new ownership model.

Fixes #407

New Features #408

Contract References: Updated existing @icontract/@beartype-guarded CLI surfaces for grouped command ownership and prompt/runtime validation. No new public contract decorators were introduced beyond the command-surface refactor.

Type of Change

Please check all that apply:

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Contract enforcement (adding/updating @icontract decorators)
  • 🧪 Test enhancement (scenario tests, property-based tests)
  • 🔧 Refactoring (code improvement without functionality change)

Contract-First Testing Evidence

Required for all changes affecting CLI commands or public APIs:

Contract Validation

  • Runtime contracts added/updated (@icontract decorators on public APIs)
  • Type checking enforced (@beartype decorators applied)
  • CrossHair exploration completed: hatch run contract-test-exploration
  • Contract violations reviewed and addressed

Test Execution

  • Contract validation: hatch run contract-test-contracts
  • Contract exploration: hatch run contract-test-exploration
  • Scenario tests: hatch run contract-test-scenarios
  • Full test suite: hatch run contract-test-full

Test Quality

  • CLI commands tested with typer test client
  • Edge cases covered with Hypothesis property tests
  • Error handling tested with invalid inputs
  • Rich console output verified manually or with snapshots

How Has This Been Tested?

Contract-First Approach: Added ownership-focused regression coverage for the grouped CLI surface and command audit inventory, then validated the temp-home marketplace install/runtime path that previously missed code import.

Manual Testing

  • Tested CLI commands manually
  • Verified rich console output
  • Tested with different input scenarios
  • Checked error messages for clarity

Automated Testing

  • Contract validation passes
  • Property-based tests cover edge cases
  • Scenario tests cover user workflows
  • All existing tests still pass

Test Environment

  • Python version: 3.12
  • OS: Ubuntu (worktree sandbox)

Checklist

  • My code follows the style guidelines (PEP 8, ruff format, isort)
  • I have performed a self-review of my code
  • I have added/updated contracts (@icontract, @beartype)
  • I have added/updated docstrings (Google style)
  • I have made corresponding changes to documentation
  • My changes generate no new warnings (basedpyright, ruff, pylint)
  • All tests pass locally
  • I have added tests that prove my fix/feature works
  • Any dependent changes have been merged

Quality Gates Status

  • Type checking ✅ (hatch run type-check)
  • Linting ✅ (hatch run lint)
  • Contract validation ✅ (hatch run contract-test-contracts)
  • Contract exploration ✅ (hatch run contract-test-exploration)
  • Scenario tests ✅ (hatch run contract-test-scenarios)

Screenshots/Recordings (if applicable)

Add screenshots or recordings of CLI output, especially for new commands or UI changes.

@djm81 djm81 self-assigned this Mar 11, 2026
@djm81 djm81 added bug Something isn't working module-system Module system and registry marketplace Module marketplace features labels Mar 11, 2026
@djm81 djm81 linked an issue Mar 11, 2026 that may be closed by this pull request
djm81 and others added 2 commits March 12, 2026 00:18
…wnership-realignment

Signed-off-by: Dom <39115308+djm81@users.noreply.github.com>
@djm81 djm81 merged commit 67aaf31 into dev Mar 12, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working marketplace Module marketplace features module-system Module system and registry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Change] module-migration-11 - Project And Codebase Ownership Realignment

1 participant