Conversation
…ction Replace the parser unit tests added in nodejs#5827 with one test in the shape of the other websocket tests: a ws server negotiates permessage-deflate, sends a compressed message, then writes a bare continuation frame. The client must receive the message and the connection must fail with 1002 Unexpected continuation frame. The unit tests reached into the parser's handler and sequenced frames with timers; they are removed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #5827 after @KhafraDev's comments there.
The unit tests that PR added to
test/websocket/receiver-unit.jsbuilt a fake of the parser's handler and sequenced frames with timers. They are removed here and replaced with one test in the shape ofcontinuation-frames.jsandfragments.js: awsserver negotiates permessage-deflate, sends a compressed message, then writes a bare continuation frame to the socket. The client must receive the message, and the connection must fail with1002 Unexpected continuation frame.With the fix from #5827 reverted locally the test fails (the continuation frame is accepted and the client never closes); with it, it passes.
eslintis clean on both files.Sorry for the extra work on the first round.