Skip to content

fix cache.addAll and cache.add hanging - #5844

Merged
mcollina merged 1 commit into
nodejs:mainfrom
KhafraDev:issue-5615
Sep 21, 2026
Merged

mcollina merged 1 commit into
nodejs:mainfrom
KhafraDev:issue-5615

Conversation

@KhafraDev

Copy link
Copy Markdown
Member

Fixes #5615

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@KhafraDev

Copy link
Copy Markdown
Member Author

I tried using Claude to help me investigate this issue. Big mistakes. Sometimes this technology feels like magic and sometimes it feels like it took me longer to diagnose the bug with it than without. It tries cutting corners whenever it can no matter how strongly I try prompting/guiding it. It definitely reaffirmed by belief that it shouldn't touch the web specs in any way, shape, or form yet, unless Opus 5 is generally suckish (I use it over Fable for the much better usage limits).

The AI issue also blames #3093 for this despite it NOT being the cause, which steered me away from the actual cause for a bit. 🫠

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.88%. Comparing base (164a354) to head (67575b7).

Files with missing lines Patch % Lines
lib/web/fetch/index.js 94.73% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5844      +/-   ##
==========================================
+ Coverage   93.52%   93.88%   +0.35%     
==========================================
  Files         110      110              
  Lines       39773    39800      +27     
==========================================
+ Hits        37199    37367     +168     
+ Misses       2574     2433     -141     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
mcollina merged commit 7ce2cc1 into nodejs:main Sep 21, 2026
36 of 38 checks passed
@KhafraDev
KhafraDev deleted the issue-5615 branch September 21, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cache.add() and Cache.addAll() never settle for a response with a body

3 participants