test(decompress): wait for highWaterMark via readable instead of setImmediate loop - #5841
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5841 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 110 110
Lines 39773 39773
=======================================
+ Hits 37200 37201 +1
+ Misses 2573 2572 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
test/interceptors/decompress.js(added in fix: honor backpressure in decompression interceptor #5829)bfea0201): https://github.com/nodejs/undici/actions/runs/35103603339/job/104818987490Rationale
The test waits for the body to reach
highWaterMarkwith a loop of 100setImmediateticks, which is unreliable when the threadpool is busy.Changes
Wait for
readableHighWaterMarkto be reached via thereadableevent instead of asetImmediateloop.Tests
bfea0201, before this change): https://github.com/nodejs/undici/actions/runs/35103603339/job/104818987490#step:18:301Assisted-by: Claude Code
Status