Conversation
MemoryCacheStoreOpts documents maxCount, maxSize and maxEntrySize as Infinity, and SqliteCacheStoreOpts documents maxEntrySize as Infinity. The implementation and docs/docs/api/CacheStore.md both give finite defaults. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011e7REh3NDrdszg2xJdd5Qy
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
types/cache-interceptor.d.tsgives@default Infinityfor four cache store options that are bounded. The implementation anddocs/docs/api/CacheStore.mdagree with each other; only the.d.tsdisagrees.A 6 MiB response is silently not cached under defaults, which the types say cannot happen. Corrected the four tags to match.