Skip to content

fix(cache): track cached response abort state - #5820

Open
mcollina wants to merge 2 commits into
mainfrom
fix/cache-controller-aborted
Open

mcollina wants to merge 2 commits into
mainfrom
fix/cache-controller-aborted

Conversation

@mcollina

Copy link
Copy Markdown
Member

Track cached-response controller abort state independently from the backing stream lifecycle, so normal cache completion no longer reports an abort. Adds regression coverage for the cache-hit path.

Fixes #5818

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov-commenter

codecov-commenter commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.53%. Comparing base (bfea020) to head (01fad41).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5820   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files         110      110           
  Lines       39773    39773           
=======================================
  Hits        37200    37200           
  Misses       2573     2573           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metcoder95 metcoder95 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just conflicts and lgtm

…aborted

Signed-off-by: Matteo Collina <hello@matteocollina.com>

# Conflicts:
#	lib/interceptor/cache.js

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cache interceptor reports aborted=true during successful onResponseEnd

3 participants