Skip to content

fix(retry): settle responses after connection close - #5815

Open
mcollina wants to merge 1 commit into
mainfrom
fix/retry-connection-close
Open

mcollina wants to merge 1 commit into
mainfrom
fix/retry-connection-close

Conversation

@mcollina

Copy link
Copy Markdown
Member

Ensure retry responses that finish while their controller is paused are retained until the retry policy completes. This lets retries advance after a peer closes the connection and preserves the final response body when retries are exhausted.

Adds concurrent coverage for connection-closing retry responses.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.46%. Comparing base (fb3d786) to head (18ae0da).

Files with missing lines Patch % Lines
lib/handler/retry-handler.js 66.66% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5815      +/-   ##
==========================================
- Coverage   93.50%   93.46%   -0.04%     
==========================================
  Files         110      110              
  Lines       39557    39599      +42     
==========================================
+ Hits        36987    37013      +26     
- Misses       2570     2586      +16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants