Skip to content

fix(redirect): ignore informational responses in history - #5813

Merged
mcollina merged 1 commit into
mainfrom
fix/redirect-informational-history
Sep 21, 2026
Merged

mcollina merged 1 commit into
mainfrom
fix/redirect-informational-history

Conversation

@mcollina

Copy link
Copy Markdown
Member

This relates to...

N/A

Rationale

The redirect interceptor receives informational responses through onResponseStart, but they are not final responses and must not update redirect state. Adding each informational response to history also makes it incorrectly consume the configured redirect limit.

Changes

Features

N/A

Bug Fixes

  • Forward informational responses without mutating redirect state or history.
  • Add regression coverage that sends enough 102 Processing responses to exceed the configured redirect limit and verifies callback delivery and final history.

Breaking Changes and Deprecations

N/A

Status

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov-commenter

codecov-commenter commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.50%. Comparing base (fb3d786) to head (1de0ac6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5813      +/-   ##
==========================================
- Coverage   93.50%   93.50%   -0.01%     
==========================================
  Files         110      110              
  Lines       39557    39562       +5     
==========================================
+ Hits        36987    36991       +4     
- Misses       2570     2571       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina
mcollina merged commit cd10be2 into main Sep 21, 2026
38 checks passed
@mcollina
mcollina deleted the fix/redirect-informational-history branch September 21, 2026 20:00
@github-actions github-actions Bot mentioned this pull request Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants