fix: propagate dispatcher origin to composed interceptors - #5624
Open
jibin7jose wants to merge 3 commits into
Open
fix: propagate dispatcher origin to composed interceptors#5624jibin7jose wants to merge 3 commits into
jibin7jose wants to merge 3 commits into
Conversation
Co-authored-by: jibinjose884@gmail.com
mcollina
reviewed
Jul 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5624 +/- ##
==========================================
+ Coverage 93.50% 93.53% +0.02%
==========================================
Files 110 110
Lines 38451 38460 +9
==========================================
+ Hits 35955 35974 +19
+ Misses 2496 2486 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change ensures that composed interceptors receive the dispatcher origin automatically when a Client or Pool dispatches a request without an explicit origin in the request options.
What changed
Propagate the dispatcher’s base origin into request options before interceptor dispatch.
Preserve existing behavior for requests that already specify an origin.
Update interceptor regression tests to cover Client and Pool requests without an explicit origin.
Why
Some interceptors depend on opts.origin being present. Without this propagation, requests dispatched through a composed Client or Pool could bypass interceptor behavior unexpectedly.
Testing
Verified the interceptor test suite with:
npm run test:interceptors
Co-authored-by: [jibinjose884@gmail.com]