Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Pull request overview
This pull request updates the nvm (Node Version Manager) installation snippet from version 0.40.3 to 0.40.4 in the English locale file. The change aligns with the latest nvm release and follows the established translation workflow where only English source files are updated directly.
Changes:
- Updated nvm version in the English installation snippet from v0.40.3 to v0.40.4
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8643 +/- ##
=======================================
Coverage 75.07% 75.07%
=======================================
Files 104 104
Lines 9094 9094
Branches 315 315
=======================================
Hits 6827 6827
Misses 2265 2265
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
note: this is an automated PR, created by a GHA workflow on nvm. i'm hoping to sidestep arguments about what should be automated or not, and what node's responsibilities to its users are. The reality is that anything that removes burden from open source maintainers should be HIGHLY prioritized, and so this is my attempt to do just that. |
|
Would it be a problem if we automatically update the nvm version for non-English pages as well? Whenever the English page is updated, we get a notification from Crowdin and the number of untranslated strings increases. However, this change doesn't actually require any translation work. From a translator's perspective, it's not really a relevant change to process manually. |
No no, you're good. I personally even think we could do the automation here if really needed, but it does make sense too to have it on nvm-side. |
Agree, the snippets also need to be translated, if the versions on the translated snippets could be updated, that'd be great. |
Won't Crowdin handle that? |
It might consider them as new strings, IDK. |
|
In the past I updated them all at once, and was blocked until I only changed the english ones. Should I change my automation to change every language's version? |
Updates the English nvm install snippet to
v0.40.4. The translation system handles other locales.Ref: #8628