Skip to content

docs: update authors list for ESM/CJS contribution#8635

Closed
nitin-is-me wants to merge 1 commit intonodejs:mainfrom
nitin-is-me:docs-update-author
Closed

docs: update authors list for ESM/CJS contribution#8635
nitin-is-me wants to merge 1 commit intonodejs:mainfrom
nitin-is-me:docs-update-author

Conversation

@nitin-is-me
Copy link
Contributor

Description

Hi team,
I'm updating the authors list in some pages to reflect my recent contribution in PR #8619, where I added the ESM/CJS tabs and code examples in various pages in learn section. I noticed this metadata isn't automated, and authors add themselves along with their contribution.

Thanks!

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary. (N/A)

@nitin-is-me nitin-is-me requested a review from a team as a code owner February 17, 2026 04:30
@vercel
Copy link

vercel bot commented Feb 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Feb 17, 2026 4:31am

Request Review

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website @nodejs/diagnostics @nodejs/fs

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you updated snippets, it seems quite odd to mark yourself as an author of the content itself.

@nitin-is-me
Copy link
Contributor Author

While you updated snippets, it seems quite odd to mark yourself as an author of the content itself.

I thought the contributors have to mark themselves as an author after making changes to the page, for example PR #6182
Although if the site can't accept contributors as authors for page contribution, then I'll understand it.

@ovflowd
Copy link
Member

ovflowd commented Feb 17, 2026

While we appreciate your contributions, the only contribution done by you on them, was duplicating the already existing snippets and making ESM versions of them, which pretty much is just replacing require by import. this was also your only contribution

We reserve the title of author to people that have actually written significant amount of content in an article to warrant them as an author. You can see multiple people commited to these files in the past, none of them gets their name added.

So, no, you're not an author of these articles.

I thought the contributors have to mark themselves as an author after making changes to the page

Where did you get this information from?

@nitin-is-me nitin-is-me deleted the docs-update-author branch February 17, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments