docs: update authors list for ESM/CJS contribution#8635
docs: update authors list for ESM/CJS contribution#8635nitin-is-me wants to merge 1 commit intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website @nodejs/diagnostics @nodejs/fs Please review the changes when you have a chance. Thank you! 🙏 |
avivkeller
left a comment
There was a problem hiding this comment.
While you updated snippets, it seems quite odd to mark yourself as an author of the content itself.
I thought the contributors have to mark themselves as an author after making changes to the page, for example PR #6182 |
|
While we appreciate your contributions, the only contribution done by you on them, was duplicating the already existing snippets and making ESM versions of them, which pretty much is just replacing require by import. this was also your only contribution We reserve the title of author to people that have actually written significant amount of content in an article to warrant them as an author. You can see multiple people commited to these files in the past, none of them gets their name added. So, no, you're not an author of these articles.
Where did you get this information from? |
Description
Hi team,
I'm updating the authors list in some pages to reflect my recent contribution in PR #8619, where I added the ESM/CJS tabs and code examples in various pages in learn section. I noticed this metadata isn't automated, and authors add themselves along with their contribution.
Thanks!
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.