Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8627 +/- ##
=======================================
Coverage 75.05% 75.05%
=======================================
Files 104 104
Lines 9088 9088
Branches 315 315
=======================================
Hits 6821 6821
Misses 2265 2265
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
Improves the Supporters section rendering by avoiding broken/empty supporter avatars and disabling links for OpenCollective “guest” accounts (Fixes #8621).
Changes:
- Treat OpenCollective
guest-...profiles as non-linkable by clearing theprofilefield in generated supporters data. - Add a text fallback (acronym) for supporter avatars so missing images don’t render as empty circles.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/site/next-data/generators/supportersData.mjs | Adjusts OpenCollective mapping to null out guest profile links. |
| apps/site/components/Common/Supporters/index.tsx | Adds acronym-based avatar fallback for supporters. |
Comments suppressed due to low confidence (1)
apps/site/components/Common/Supporters/index.tsx:21
- With the generator now potentially producing a falsy
profile(e.g.,null/undefined) for guest supporters, pass anundefinedURL intoAvatarrather thannullto matchAvatarProps['url']?: stringand keep the typing/runtime behavior consistent (e.g.,url={profile ?? undefined}after updating theSupportertype).
fallback={getAcronymFromString(name)}
image={image}
key={`${name}-${i}`}
url={profile}
/>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Small supporters improvements
Validation
Related Issues
Fixes #8621
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.