Skip to content

feat: supporters improvements#8627

Open
araujogui wants to merge 2 commits intonodejs:mainfrom
araujogui:feat/supporters-improvements
Open

feat: supporters improvements#8627
araujogui wants to merge 2 commits intonodejs:mainfrom
araujogui:feat/supporters-improvements

Conversation

@araujogui
Copy link
Member

Description

Small supporters improvements

Validation

image

Related Issues

Fixes #8621

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@araujogui araujogui requested a review from a team as a code owner February 13, 2026 23:23
Copilot AI review requested due to automatic review settings February 13, 2026 23:23
@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Feb 13, 2026 11:32pm

Request Review

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.05%. Comparing base (70b57c5) to head (248ad0d).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8627   +/-   ##
=======================================
  Coverage   75.05%   75.05%           
=======================================
  Files         104      104           
  Lines        9088     9088           
  Branches      315      315           
=======================================
  Hits         6821     6821           
  Misses       2265     2265           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the Supporters section rendering by avoiding broken/empty supporter avatars and disabling links for OpenCollective “guest” accounts (Fixes #8621).

Changes:

  • Treat OpenCollective guest-... profiles as non-linkable by clearing the profile field in generated supporters data.
  • Add a text fallback (acronym) for supporter avatars so missing images don’t render as empty circles.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
apps/site/next-data/generators/supportersData.mjs Adjusts OpenCollective mapping to null out guest profile links.
apps/site/components/Common/Supporters/index.tsx Adds acronym-based avatar fallback for supporters.
Comments suppressed due to low confidence (1)

apps/site/components/Common/Supporters/index.tsx:21

  • With the generator now potentially producing a falsy profile (e.g., null/undefined) for guest supporters, pass an undefined URL into Avatar rather than null to match AvatarProps['url']?: string and keep the typing/runtime behavior consistent (e.g., url={profile ?? undefined} after updating the Supporter type).
        fallback={getAcronymFromString(name)}
        image={image}
        key={`${name}-${i}`}
        url={profile}
      />

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the Supporters section

3 participants