Skip to content

src: reuse crypto GetCipherInfo in DTLS session - #66022

Open
IlyasShabi wants to merge 1 commit into
nodejs:mainfrom
IlyasShabi:ishabi/dtls-getcipherinfo-crypto
Open

IlyasShabi wants to merge 1 commit into
nodejs:mainfrom
IlyasShabi:ishabi/dtls-getcipherinfo-crypto

Conversation

@IlyasShabi

Copy link
Copy Markdown
Member

Call shared crypto GetCipherInfo helper inside DTLSSession::GetCipher instead of using same code, this also using cached DictionaryTemplate.

Signed-off-by: ishabi <ilyasshabi94@gmail.com>
@IlyasShabi
IlyasShabi requested a review from jasnell September 14, 2026 12:44
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 14, 2026
@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.22%. Comparing base (0e32ee2) to head (c20e9ba).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66022      +/-   ##
==========================================
+ Coverage   90.19%   90.22%   +0.02%     
==========================================
  Files         785      785              
  Lines      269368   269368              
  Branches    51512    51503       -9     
==========================================
+ Hits       242964   243027      +63     
+ Misses      16908    16858      -50     
+ Partials     9496     9483      -13     

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added the dtls Issues and PRs related to Datagram Transport Layer Security (DTLS). label Sep 14, 2026
@meixg meixg added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 15, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. dtls Issues and PRs related to Datagram Transport Layer Security (DTLS). needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants