test: prevent parser reuse across close scenarios - #66017
Open
panva wants to merge 1 commit into
Open
Conversation
panva
added
the
flaky-test
Member
Author
|
Refs: https://ci.nodejs.org/job/node-test-commit-aix/65367/
|
nodejs-github-bot
added
needs-ci
lpinca
reviewed
Sep 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66017 +/- ##
==========================================
- Coverage 90.20% 90.20% -0.01%
==========================================
Files 785 785
Lines 269347 269347
Branches 51509 51509
==========================================
- Hits 242971 242956 -15
- Misses 16890 16900 +10
- Partials 9486 9491 +5 🚀 New features to boost your workflow:
|
Both cases replace parser cleanup methods. Faster socket cleanup can return a modified parser to the shared pool and close it before the other request uses it. Run the immediate and deferred close cases in separate test files so each gets its own process and parser pool. Preserve both cleanup paths and all call-count assertions. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
force-pushed
the
test-http-connection-list-race
branch
from
September 13, 2026 20:36
8f8e07a to
2fe4eb2
Compare
panva
added
the
request-ci
jasnell
approved these changes
Sep 13, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both cases replace parser cleanup methods. Faster socket cleanup can return a modified parser to the shared pool and close it before the other request uses it.
Run the immediate and deferred close cases in separate test files so each gets its own process and parser pool. Preserve both cleanup paths and all call-count assertions.