src,ffi: create fast-call metadata Symbols lazily

[mcollina]

The FFI fast-call wrappers key per-function metadata on raw FFI functions using two per-isolate Symbols (kFastArguments / kFastBufferInvoke) that were declared in src/env_properties.h. Everything in env_properties.h is allocated while the startup snapshot is built, so each Symbol advances the isolate's identity-hash RNG before Object.prototype / Function.prototype receive their snapshot identity hashes. In the snapshot produced for Node 26.4.0+ this shifted those hashes so a function map (a function whose length was redefined) and a plain-object map (an object literal with an accessor) collide in V8's 64-slot NormalizedMapCache. Every store into such objects then misses the inline cache, and the repro reported in the linked issue is roughly 7x slower.

Create the two Symbols lazily in the FFI binding's Initialize, on the first run of internalBinding('ffi') at runtime, instead of declaring them in env_properties.h. They are therefore not allocated during snapshot serialization and no longer bias the snapshot's prototype identity hashes. Their export, property layout, and the fast-call feature behavior are unchanged.

Fixes #66011

---

Ai generated, humanly reviewed.

[nodejs-github-bot]

Review requested:

• @nodejs/ffi

[codecov]

Codecov Report

❌ Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.00%. Comparing base (7aaf9b4) to head (9661374).
⚠️ Report is 401 commits behind head on main.

Files with missing lines	Patch %	Lines
src/env-inl.h	90.90%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #66015      +/-   ##
==========================================
- Coverage   90.13%   90.00%   -0.13%     
==========================================
  Files         751      785      +34     
  Lines      253639   269356   +15717     
  Branches    47790    51309    +3519     
==========================================
+ Hits       228618   242446   +13828     
- Misses      16264    17403    +1139     
- Partials     8757     9507     +750     

Files with missing lines	Coverage Δ
src/env.h	97.22% <ø> (-1.00%)	⬇️
src/node_ffi.cc	72.34% <100.00%> (+0.62%)	⬆️
src/env-inl.h	93.92% <90.90%> (-1.11%)	⬇️

... and 260 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Renegade334]

Is this just kicking the can down the road? Is this behaviour going to be reintroduced some other time someone decides to define a new environment symbol?

[mcollina]

Is this just kicking the can down the road? Is this behaviour going to be reintroduced some other time someone decides to define a new environment symbol?

Yes. However we can't assume when the V8 fix is going to land, and this seems better than reverting the ffi change.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/77436/