Skip to content

tools: harden GitHub Actions workflows - #66013

Open
panva wants to merge 4 commits into
nodejs:mainfrom
panva:zizmor-workflow-cleanup
Open

tools: harden GitHub Actions workflows#66013
panva wants to merge 4 commits into
nodejs:mainfrom
panva:zizmor-workflow-cleanup

Conversation

@panva

@panva panva commented Sep 13, 2026

Copy link
Copy Markdown
Member

Address easy actionable findings from zizmor, a static analysis tool that checks GitHub Actions workflows:

  • Pass dynamic values through environment variables instead of inserting them directly into shell scripts. Use arrays for benchmark categories and PR numbers.
  • Resolve local actions and reusable workflows from the running workflow commit using $/ references, removing redundant action checkouts.
  • Disable checkout credential persistence for CodeQL.
  • Correct Slack action version comments.

Disable credential persistence for CodeQL.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
Resolve local actions and reusable workflows from the running
workflow commit with $/ references, independent of checkout paths.

Remove the tarball job's action-only checkout and the WPT action
checkout/copy workaround, which are no longer needed.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
Pass input, output, and version values through environment variables
instead of expanding them into shell source. Split benchmark
categories and PR numbers into arrays to retain separate arguments.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
@panva
panva requested a review from aduh95 September 13, 2026 10:11
@panva panva added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Sep 13, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 13, 2026
@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants