Skip to content

test: skip test-vfs-real-provider-watch.js and bench-watch-recursive.js on IBM i - #65987

Open
sravani1510 wants to merge 1 commit into
nodejs:mainfrom
sravani1510:ibmi-skip-fs-watch-test
Open

test: skip test-vfs-real-provider-watch.js and bench-watch-recursive.js on IBM i#65987
sravani1510 wants to merge 1 commit into
nodejs:mainfrom
sravani1510:ibmi-skip-fs-watch-test

Conversation

@sravani1510

@sravani1510 sravani1510 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

fs.watch is not supported on IBM i so the test failed
jenkins build log - https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi74-ppc64/

not ok 4889 parallel/test-vfs-real-provider-watch
17:24:40   ---
17:24:40   duration_ms: 1975.60700
17:24:40   severity: fail
17:24:40   exitcode: 1
17:24:40   stack: |-
17:24:40     node:internal/fs/watchers:331
17:24:40         throw error;
17:24:40         ^
17:24:40     
17:24:40     Error: ENOSYS: function not implemented, watch '/home/IOJS/build/.tmp.4888/real-provider-watch/watch-me.txt'
17:24:40         at FSWatcher.<computed> (node:internal/fs/watchers:323:19)
17:24:40         at Object.watch (node:fs:3156:36)
17:24:40         at RealFSProvider.watch (node:internal/vfs/providers/real:549:15)
17:24:40         at VirtualFileSystem.watch (node:internal/vfs/file_system:1053:37)
17:24:40         at Object.<anonymous> (/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/test/parallel/test-vfs-real-provider-watch.js:23:25)
17:24:40         at Module._compile (node:internal/modules/cjs/loader:1956:14)
17:24:40         at Object..js (node:internal/modules/cjs/loader:2096:10)
17:24:40         at Module.load (node:internal/modules/cjs/loader:1678:32)
17:24:40         at Module._load (node:internal/modules/cjs/loader:1470:12)
17:24:40         at wrapModuleLoad (node:internal/modules/cjs/loader:261:19) {
17:24:40       errno: -109,
17:24:40       syscall: 'watch',
17:24:40       code: 'ENOSYS',
17:24:40       path: '/home/IOJS/build/.tmp.4888/real-provider-watch/watch-me.txt',
17:24:40       filename: '/home/IOJS/build/.tmp.4888/real-provider-watch/watch-me.txt'
17:24:40     }
17:24:40     
17:24:40     Node.js v27.0.0-pre
17:24:40   ...


not ok 5910 benchmark/test-benchmark-fs
17:56:47   ---
17:56:47   duration_ms: 124424.17800
17:56:47   severity: fail
17:56:47   exitcode: 1
17:56:47   stack: |-
17:56:47     (node:10111406) ExperimentalWarning: stream/iter is an experimental feature and might change at any time
17:56:47     (Use `node --trace-warnings ...` to show where the warning was created)
17:56:47     (node:10111406) ExperimentalWarning: zlib/iter is an experimental feature and might change at any time
17:56:47     node:internal/fs/recursive_watch:336
17:56:47             throw error;
17:56:47             ^
17:56:47     
17:56:47     Error: ENOSYS: function not implemented, watch '/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/lib'
17:56:47         at FSWatcher.<computed> (node:internal/fs/watchers:323:19)
17:56:47         at watch (node:fs:3156:36)
17:56:47         at #watch (node:internal/fs/recursive_watch:171:17)
17:56:47         at #scanFolder (node:internal/fs/recursive_watch:187:21)
17:56:47         at [kFSWatchStart] (node:internal/fs/recursive_watch:328:25)
17:56:47         at Object.watch (node:fs:3153:36)
17:56:47         at main (/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/benchmark/fs/bench-watch-recursive.js:20:8)
17:56:47         at /home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/benchmark/common.js:64:9
17:56:47         at process.processTicksAndRejections (node:internal/process/task_queues:85:11) {
17:56:47       errno: -109,
17:56:47       syscall: 'watch',
17:56:47       code: 'ENOSYS',
17:56:47       path: '/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/lib',
17:56:47       filename: '/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/lib'
17:56:47     }
17:56:47     
17:56:47     Node.js v27.0.0-pre
17:56:47     node:internal/process/promises:322
17:56:47           new UnhandledPromiseRejection(reason);
17:56:47           ^
17:56:47     
17:56:47     UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "1".
17:56:47         at throwUnhandledRejectionsMode (node:internal/process/promises:322:7)
17:56:47         at processPromiseRejections (node:internal/process/promises:405:17)
17:56:47         at process.processTicksAndRejections (node:internal/process/task_queues:106:37) {
17:56:47       code: 'ERR_UNHANDLED_REJECTION'
17:56:47     }
17:56:47     
17:56:47     Node.js v27.0.0-pre
17:56:47     node:internal/assert/utils:146
17:56:47       throw error;
17:56:47       ^
17:56:47     
17:56:47     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
17:56:47     
17:56:47     1 !== 0
17:56:47     
17:56:47         at ChildProcess.<anonymous> (/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi74-ppc64/test/common/benchmark.js:28:12)
17:56:47         at ChildProcess.emit (node:events:514:20)
17:56:47         at ChildProcess._handle.onexit (node:internal/child_process:323:12) {
17:56:47       generatedMessage: true,
17:56:47       code: 'ERR_ASSERTION',
17:56:47       actual: 1,
17:56:47       expected: 0,
17:56:47       operator: 'strictEqual',
17:56:47       diff: 'simple'
17:56:47     }
17:56:47     
17:56:47     Node.js v27.0.0-pre
17:56:47   ...

After skipping the test, jenkins build - https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi74-ppc64/2462/console

ok 4889 parallel/test-vfs-real-provider-watch # skip IBMi does not support `fs.watch()`
20:52:14   ---
20:52:14   duration_ms: 1867.03100
20:52:14   ...

ok 5910 benchmark/test-benchmark-fs
  ---
  duration_ms: 163807.40900
  ...

Ref: #52640

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 11, 2026
Signed-off-by: Gundepalli Sravani <Gundepalli.Sravani1@ibm.com>
@sravani1510
sravani1510 force-pushed the ibmi-skip-fs-watch-test branch from 0528e87 to 77d8446 Compare September 11, 2026 17:19
@sravani1510

Copy link
Copy Markdown
Contributor Author

CC:
@nodejs/platform-aix
@nodejs/platform-ibmi

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.98%. Comparing base (0de4fcc) to head (77d8446).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65987      +/-   ##
==========================================
- Coverage   90.17%   89.98%   -0.19%     
==========================================
  Files         771      784      +13     
  Lines      265470   268263    +2793     
  Branches    50463    51094     +631     
==========================================
+ Hits       239383   241392    +2009     
- Misses      17055    17427     +372     
- Partials     9032     9444     +412     

see 77 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 11, 2026

@lpinca lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a skipIfNoWatch() utility in test/common/watch.js

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 11, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@abmusse abmusse added the ibm i Issues and PRs related to the IBM i platform. label Sep 11, 2026
@sravani1510 sravani1510 changed the title test: skip test-vfs-real-provider-watch.js on IBM i test: skip test-vfs-real-provider-watch.js and bench-watch-recursive.js on IBM i Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ibm i Issues and PRs related to the IBM i platform. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants