test: avoid allocations in external memory test - #65975
Open
panva wants to merge 4 commits into
Open
Conversation
Inspect the parsed V8 flags instead of allocating over a gigabyte and aborting child processes. This avoids memory pressure and core dumps in test-external-memory-reasonable-size. Also verify that Node disables the limit by default. Refs: nodejs#65780 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
added
the
flaky-test
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65975 +/- ##
==========================================
- Coverage 90.17% 90.17% -0.01%
==========================================
Files 771 771
Lines 265470 265451 -19
Branches 50463 50459 -4
==========================================
- Hits 239383 239362 -21
+ Misses 17055 17046 -9
- Partials 9032 9043 +11 🚀 New features to boost your workflow:
|
aduh95
reviewed
Sep 11, 2026
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
panva
added
the
commit-queue-squash
aduh95
reviewed
Sep 11, 2026
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Sep 11, 2026
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
panva
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
richardlau
approved these changes
Sep 11, 2026
jasnell
approved these changes
Sep 11, 2026
Collaborator
panva
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspect the parsed V8 flags instead of allocating over a gigabyte and aborting child processes. This avoids memory pressure and core dumps in test-external-memory-reasonable-size.
Also verify that Node disables the limit by default.
Refs: #65780
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-09-11.md
Assisted-by: Codex