Skip to content

tools: do not download build tools when linting Nix files - #65961

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:lint-nix
Sep 12, 2026
Merged

nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:lint-nix

Conversation

@aduh95

@aduh95 aduh95 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Nix linter output currently reads these 72 paths will be fetched (135.5 MiB download, 445.1 MiB unpacked). Most of those are not actually used, because nix-shell defaults to providing build tools and its own Bash we simply don't need.

In this PR, the workflow shows these 33 paths will be fetched (27.0 MiB download, 86.4 MiB unpacked)

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 10, 2026
@aduh95
aduh95 requested review from cjihrig and panva September 11, 2026 09:59
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 11, 2026
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Sep 11, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 6e85052 into nodejs:main Sep 12, 2026
44 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 6e85052

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants