Skip to content

permission: support v8.setHeapSnapshotNearHeapLimit - #64808

Open
IlyasShabi wants to merge 1 commit into
nodejs:mainfrom
IlyasShabi:ishabi/near-heap-limit-permission
Open

permission: support v8.setHeapSnapshotNearHeapLimit#64808
IlyasShabi wants to merge 1 commit into
nodejs:mainfrom
IlyasShabi:ishabi/near-heap-limit-permission

Conversation

@IlyasShabi

Copy link
Copy Markdown
Member

This adds a file permission check before registering the near-heap-limit callback when using v8.setHeapSnapshotNearHeapLimit() to avoid writing a heap snapshot without permission.

Signed-off-by: ishabi <ilyasshabi94@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@IlyasShabi
IlyasShabi requested a review from RafaelGSS July 28, 2026 13:57
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jul 28, 2026
@avivkeller avivkeller added the permission Issues and PRs related to the Permission Model label Jul 28, 2026
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.16%. Comparing base (b2a024b) to head (492a8b6).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/node_v8.cc 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64808   +/-   ##
=======================================
  Coverage   90.15%   90.16%           
=======================================
  Files         744      744           
  Lines      242542   242547    +5     
  Branches    45690    45694    +4     
=======================================
+ Hits       218672   218681    +9     
  Misses      15362    15362           
+ Partials     8508     8504    -4     
Files with missing lines Coverage Δ
src/node_v8.cc 87.86% <60.00%> (-0.45%) ⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@IlyasShabi IlyasShabi added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@IlyasShabi IlyasShabi added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants