Skip to content

doc: report proper return type on url.format - #64806

Open
bmuenzenmeyer wants to merge 3 commits into
nodejs:mainfrom
bmuenzenmeyer:url-return-string
Open

doc: report proper return type on url.format#64806
bmuenzenmeyer wants to merge 3 commits into
nodejs:mainfrom
bmuenzenmeyer:url-return-string

Conversation

@bmuenzenmeyer

@bmuenzenmeyer bmuenzenmeyer commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Derived from nodejs/doc-kit#953
Verified with local doc-kit run

image

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Jul 28, 2026
Renegade334
Renegade334 reviewed Jul 28, 2026
View reviewed changes
Comment thread doc/api/url.md
avivkeller
avivkeller reviewed Jul 28, 2026
View reviewed changes
Comment thread doc/api/url.md Outdated
Comment thread doc/api/url.md Outdated
bmuenzenmeyer and others added 3 commits July 28, 2026 20:51
@bmuenzenmeyer
doc: report proper return type on url.format
c15a4f8 
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@bmuenzenmeyer
add return type to override
505add9
@bmuenzenmeyer @avivkeller
chore: remove whitespace
a1fc980 
Co-authored-by: Aviv Keller <me@aviv.sh>
@Renegade334 Renegade334 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 29, 2026
@bmuenzenmeyer bmuenzenmeyer mentioned this pull request Jul 29, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkeller avivkeller avivkeller left review comments
@lpinca lpinca lpinca approved these changes
@Renegade334 Renegade334 Renegade334 approved these changes
+2 more reviewers
@mertcanaltin mertcanaltin mertcanaltin approved these changes
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bmuenzenmeyer @lpinca @Renegade334 @mertcanaltin @avivkeller @bjohansebas @nodejs-github-bot