repl: keep entries added while history file is loading#64513
Open
mhayk wants to merge 1 commit into
Open
Conversation
Lines can be evaluated while the history file is still being read asynchronously by setupHistory(), e.g. when the input stream does not support pausing. The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history. Merge the persisted entries with the in-memory ones instead. Refs: nodejs#64508 Signed-off-by: Mhayk Whandson <hi@mhayk.com>
f9f897d to
76d0f74
Compare
avivkeller
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lines can be evaluated while the history file is still being read asynchronously by
setupHistory(), e.g. when the input stream does not support pausing (programmatic REPLs driven by mock streams, sockets or pipes). The entries added to the in-memory history in the meantime were discarded once the file load completed, because the loaded entries overwrote the in-memory history, leaving the history file without those entries.This change merges the persisted entries with the in-memory ones instead (newest first, capped at the configured history size).
Reproduction on
mainbefore this change:After this change,
r.historyis['const b = 2', 'const a = 1', 'persisted entry']and the file is flushed accordingly.Refs: #64508