Skip to content

stream: reduce allocations on WHATWG streams hot paths #63876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcollina wants to merge 1 commit into
base: main
Choose a base branch
from
+484 −297
Open

stream: reduce allocations on WHATWG streams hot paths #63876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions benchmark/webstreams/creation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ const bench = common.createBenchmark(main, {

'ReadableStream.tee',
],
}, {
// Each case collects garbage right before bench.start() so that the
// timed window measures the work under test rather than leftover
// GC work from the setup phase.
flags: ['--expose-gc'],
});

let readableStream;
Expand All @@ -33,6 +38,7 @@ let teeResult;
function main({ n, kind }) {
switch (kind) {
case 'ReadableStream':
globalThis.gc();
bench.start();
for (let i = 0; i < n; ++i)
readableStream = new ReadableStream();
Expand All @@ -42,6 +48,7 @@ function main({ n, kind }) {
assert.ok(readableStream);
break;
case 'WritableStream':
globalThis.gc();
bench.start();
for (let i = 0; i < n; ++i)
writableStream = new WritableStream();
Expand All @@ -51,6 +58,7 @@ function main({ n, kind }) {
assert.ok(writableStream);
break;
case 'TransformStream':
globalThis.gc();
bench.start();
for (let i = 0; i < n; ++i)
transformStream = new TransformStream();
Expand All @@ -62,6 +70,7 @@ function main({ n, kind }) {
case 'ReadableStreamDefaultReader': {
const readers = Array.from({ length: n }, () => new ReadableStream());

globalThis.gc();
bench.start();
for (let i = 0; i < n; ++i)
readableStreamDefaultReader = new ReadableStreamDefaultReader(readers[i]);
Expand All @@ -74,6 +83,7 @@ function main({ n, kind }) {
case 'ReadableStreamBYOBReader': {
const readers = Array.from({ length: n }, () => new ReadableStream({ type: 'bytes' }));

globalThis.gc();
bench.start();
for (let i = 0; i < n; ++i)
readableStreamBYOBReader = new ReadableStreamBYOBReader(readers[i]);
Expand All @@ -86,6 +96,7 @@ function main({ n, kind }) {
case 'ReadableStream.tee': {
const streams = Array.from({ length: n }, () => new ReadableStream());

globalThis.gc();
bench.start();
for (let i = 0; i < n; ++i)
teeResult = streams[i].tee();
Expand Down
Loading
Loading