Skip to content

crypto: reject non-positive RSA modulus in certificates #63871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
builtbyashwin wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

crypto: reject non-positive RSA modulus in certificates #63871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/crypto/crypto_x509.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,12 @@ MaybeLocal<Object> GetPubKey(Environment* env, const ncrypto::Rsa& rsa) {
}

MaybeLocal<Value> GetModulusString(Environment* env, const BIGNUM* n) {
// FIX: Reject non-positive modulus (zero or negative)
// Addresses issue #63824
if (n == nullptr || BN_is_zero(n) || BN_is_negative(n)) {
return Undefined(env->isolate());
}

auto bio = BIOPointer::New(n);
if (!bio) [[unlikely]]
return {};
Expand Down
Loading