Skip to content

sea: add test and update docs for import() with code cache#62678

Open
thisalihassan wants to merge 2 commits intonodejs:mainfrom
thisalihassan:sea/import-with-code-cache
Open

sea: add test and update docs for import() with code cache#62678
thisalihassan wants to merge 2 commits intonodejs:mainfrom
thisalihassan:sea/import-with-code-cache

Conversation

@thisalihassan
Copy link
Copy Markdown
Contributor

  • Remove the **Note:** import() does not work when useCodeCache is true. restriction from the API documentation.

Assisted by: Claude Opus 4.6

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Apr 10, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.80%. Comparing base (de5644c) to head (731eff1).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62678      +/-   ##
==========================================
- Coverage   89.81%   89.80%   -0.02%     
==========================================
  Files         699      699              
  Lines      216235   216465     +230     
  Branches    41336    41380      +44     
==========================================
+ Hits       194216   194387     +171     
- Misses      14129    14150      +21     
- Partials     7890     7928      +38     
Files with missing lines Coverage Δ
src/node_sea.cc 89.53% <ø> (ø)

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>
@thisalihassan thisalihassan force-pushed the sea/import-with-code-cache branch from c3bb922 to ead9914 Compare April 10, 2026 20:26
…amic-import.js

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants