Skip to content

tools: revert OpenSSL update workflow to ubuntu-latest#62627

Merged
nodejs-github-bot merged 1 commit intomainfrom
update-openssl-noslim
Apr 7, 2026
Merged

tools: revert OpenSSL update workflow to ubuntu-latest#62627
nodejs-github-bot merged 1 commit intomainfrom
update-openssl-noslim

Conversation

@richardlau
Copy link
Copy Markdown
Member

@richardlau richardlau commented Apr 7, 2026

Workflow requires Docker, which is not available in ubuntu-slim.

Refs: #62625

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 7, 2026
@richardlau
Copy link
Copy Markdown
Member Author

This can be closed if #62628 works.
(Although since we don't run this workflow that often, I question if we are actually saving much by running on the slim runner.)

@Renegade334
Copy link
Copy Markdown
Member

Regenerating the sources is dockerised, so this definitely won't work on ubuntu-slim!

@richardlau
Copy link
Copy Markdown
Member Author

This can be closed if #62628 works. (Although since we don't run this workflow that often, I question if we are actually saving much by running on the slim runner.)

It doesn't. The workflow needs to run Docker and that isn't available on the slim images.
https://github.com/nodejs/node/actions/runs/24096825003/job/70297457142#step:5:112

docker build -t node-openssl-builder deps/openssl/config/
ERROR: failed to connect to the docker API at unix:///var/run/docker.sock; check if the path is correct and if the daemon is running: dial unix /var/run/docker.sock: connect: no such file or directory
make: *** [Makefile:1678: gen-openssl] Error 1

I'll update the commit description.

@richardlau richardlau force-pushed the update-openssl-noslim branch from 40f5b3b to ff3d9c7 Compare April 7, 2026 18:18
Workflow requires Docker, which is not available in `ubuntu-slim`.

Signed-off-by: Richard Lau <richard.lau@ibm.com>
@richardlau richardlau force-pushed the update-openssl-noslim branch from ff3d9c7 to 341655b Compare April 7, 2026 18:24
@richardlau richardlau added the fast-track PRs that do not need to wait for 72 hours to land. label Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Fast-track has been requested by @richardlau. Please 👍 to approve.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 7, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 7, 2026
@nodejs-github-bot nodejs-github-bot merged commit 8a48913 into main Apr 7, 2026
21 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Landed in 8a48913

@nodejs-github-bot nodejs-github-bot deleted the update-openssl-noslim branch April 7, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 72 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants