-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
test_runner: print coverage and diagnostics with dot reporter #61891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
madkate42
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
madkate42:fix-dot-reporter-coverage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+86
−1
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
test/fixtures/test-runner/output/dot_reporter_coverage.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // Flags: --experimental-test-coverage --test-coverage-lines=99 | ||
| // here we can't import common module as the coverage will be different based on the system | ||
| // Unused imports are here in order to populate the coverage report | ||
| // eslint-disable-next-line no-unused-vars | ||
| import * as a from '../coverage-snap/b.js'; | ||
| // eslint-disable-next-line no-unused-vars | ||
| import * as b from '../coverage-snap/a.js'; | ||
|
|
||
| import { test } from 'node:test'; | ||
|
|
||
| process.stdout.columns = 80; | ||
|
|
||
| test('passing test for dot coverage report'); |
19 changes: 19 additions & 0 deletions
19
test/fixtures/test-runner/output/dot_reporter_coverage.snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| . | ||
|
|
||
| ℹ Error: *% line coverage does not meet threshold of 99%. | ||
| ℹ start of coverage report | ||
| ℹ ------------------------------------------------------------------------------ | ||
| ℹ file | line % | branch % | funcs % | uncovered lines | ||
| ℹ ------------------------------------------------------------------------------ | ||
| ℹ test | | | | | ||
| ℹ fixtures | | | | | ||
| ℹ test-runner | | | | | ||
| ℹ coverage-snap | | | | | ||
| ℹ a.js | 55.77 | 100.00 | 0.00 | 5-7 9-11 13-15 17-… | ||
| ℹ b.js | 45.45 | 100.00 | 0.00 | 5-7 9-11 | ||
| ℹ output | | | | | ||
| ℹ dot_reporter_cove….mjs | 100.00 | 100.00 | 100.00 | | ||
| ℹ ------------------------------------------------------------------------------ | ||
| ℹ all files | 61.84 | 100.00 | 0.00 | | ||
| ℹ ------------------------------------------------------------------------------ | ||
| ℹ end of coverage report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Test that the output of test-runner/output/dot_reporter_coverage.mjs matches | ||
| // test-runner/output/dot_reporter_coverage.snapshot | ||
| import * as common from '../common/index.mjs'; | ||
| import * as fixtures from '../common/fixtures.mjs'; | ||
| import { spawnAndAssert, defaultTransform, ensureCwdIsProjectRoot } from '../common/assertSnapshot.js'; | ||
|
|
||
| if (!process.features.inspector) { | ||
| common.skip('inspector support required'); | ||
| } | ||
|
|
||
| ensureCwdIsProjectRoot(); | ||
| await spawnAndAssert( | ||
| fixtures.path('test-runner/output/dot_reporter_coverage.mjs'), | ||
| defaultTransform, | ||
| { flags: ['--test-reporter=dot', '--test-coverage-exclude=!test/**'] }, | ||
| ); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a snapshot test too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great catch, thank you, added in this commit.
let me know if this could be improved!