Skip to content

[v22.x] src: use std::sort in node_metadata for libc++13 compatibility #61789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rebroad wants to merge 1 commit into
base: v22.x-staging
Choose a base branch
from
Open

[v22.x] src: use std::sort in node_metadata for libc++13 compatibility #61789

rebroad wants to merge 1 commit into from
+3 −2

Conversation

@rebroad
Copy link

@rebroad rebroad commented Feb 12, 2026

Summary

This replaces std::ranges::sort() with std::sort(begin, end, ...) in src/node_metadata.cc.

Motivation

On armhf + clang-13/libc++13, std::ranges::sort is unavailable, causing Node v22 build failure.

Testing

  • Built on armhf (Raspberry Pi 3, 32-bit userspace)
  • Command: make -j2

Notes

  • No behavior change intended; sorting semantics are unchanged.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Feb 12, 2026
@rebroad rebroad changed the base branch from v22.x to v22.x-staging February 12, 2026 15:00
@rebroad rebroad changed the title src: use std::sort in node_metadata for libc++13 compatibility [v22.x] src: use std::sort in node_metadata for libc++13 compatibility Feb 12, 2026
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2026
@addaleax
Copy link
Member

addaleax commented Feb 12, 2026

Would be nice to add a note about why this doesn't affect 24.x and above in the commit message, though

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 12, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71324/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rebroad @addaleax @nodejs-github-bot @lpinca