-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
doc: fix riscv64 info in platform list #61760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Han Gao <gaohan@iscas.ac.cn>
|
Review requested:
|
sxa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it depends on which levels we want to include in here. The unofficial builds are building with a later glibc than the ones in this PR so we'd have to be careful to ensure that the project does not mislead people (or not notice when the required level increased). Having said that, I'm also not certain how these were determined. I suspect most versions of node could still build with earlier ones than those listed in this doc.
Some of the earlier unofficial-builds on this platform were built against an older glibc as I recall but that was moved up when the cross-compiler environment was updated last year.
This value is loong64, the version that first appeared in the Linux kernel and glibc, but riscv64 is not. |
Yep understood (I had a Beagle-V beta RISC-V board with the version of Fedora with that glibc). However for other architectures we list glibc2.28 and that's not just because the platform support was added in those versions - it's what we have built on and so we know that it works. Having said that as an unofficial platform if it can still be confirmed that node will build against 2.27 I'd probably be ok with stating that level in here. |
No description provided.