Skip to content

Conversation

@legendecas
Copy link
Member

The certs could be allocated in a pooled buffer, like Buffer.from, and
Buffer.allocUnsafe (used by fs.readFileSync, etc).

Refs: #61372

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 16, 2026
@legendecas legendecas added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Jan 16, 2026
Copy link
Member

@Renegade334 Renegade334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to suggest a similar approach.

The commit message should probably reflect that this applies to all buffer-based quic options, not just SessionOptions#certs.

@legendecas legendecas force-pushed the quic-certs branch 2 times, most recently from da77e1e to b8f90b8 Compare January 16, 2026 21:27
@legendecas legendecas changed the title quic: copy options.certs buffer instead of detaching quic: copy optionsbuffer instead of detaching Jan 16, 2026
@legendecas legendecas changed the title quic: copy optionsbuffer instead of detaching quic: copy options buffer instead of detaching Jan 16, 2026
The certs could be allocated in a pooled buffer, like `Buffer.from`, and
`Buffer.allocUnsafe` (used by `fs.readFileSync`, etc).
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.51%. Comparing base (e3071d5) to head (7a9130c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/quic/data.cc 52.63% 9 Missing ⚠️
src/quic/tlscontext.cc 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61403      +/-   ##
==========================================
- Coverage   88.53%   88.51%   -0.02%     
==========================================
  Files         704      704              
  Lines      208797   208806       +9     
  Branches    40316    40308       -8     
==========================================
- Hits       184857   184834      -23     
- Misses      15923    15971      +48     
+ Partials     8017     8001      -16     
Files with missing lines Coverage Δ
src/quic/data.h 36.36% <ø> (-27.28%) ⬇️
src/quic/endpoint.cc 56.64% <100.00%> (+0.12%) ⬆️
src/quic/tlscontext.cc 37.47% <25.00%> (+0.62%) ⬆️
src/quic/data.cc 52.08% <52.63%> (-2.67%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants