sqlite: create options benchmarks #61401
Open
+184
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
H4ad
reviewed
Jan 16, 2026
Member
H4ad
left a comment
H4ad
left a comment
There was a problem hiding this comment.
Hey, thanks for the PR.
I think it would be better to have another benchmark just to test the impact of these options, to keep the running time low instead of increasing the combinations of a single benchmark and raise the amount of time it takes to run.
H4ad
reviewed
Jan 16, 2026
Comment on lines
+10
to
+22
| 'SELECT 1', | ||
| 'SELECT * FROM foo LIMIT 1', | ||
| 'SELECT * FROM foo LIMIT 100', | ||
| 'SELECT text_column FROM foo LIMIT 1', | ||
| 'SELECT text_column FROM foo LIMIT 100', | ||
| 'SELECT text_column, integer_column FROM foo LIMIT 1', | ||
| 'SELECT text_column, integer_column FROM foo LIMIT 100', | ||
| 'SELECT text_column, integer_column, real_column FROM foo LIMIT 1', | ||
| 'SELECT text_column, integer_column, real_column FROM foo LIMIT 100', | ||
| 'SELECT text_column, integer_column, real_column, blob_column FROM foo LIMIT 1', | ||
| 'SELECT text_column, integer_column, real_column, blob_column FROM foo LIMIT 100', | ||
| 'SELECT text_8kb_column FROM foo_large LIMIT 1', | ||
| 'SELECT text_8kb_column FROM foo_large LIMIT 100', |
Member
There was a problem hiding this comment.
I don't think is worthy to have this many variations
Maybe just select the most signification one (line 11 and 12)
And then combine the three benchmarks into one with: options: 'none, returnArrays, returnBigInt, returnArray|returnBigInts'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an options config to the
sqlitebenchmarks to measure the performance impact of different database configurations.