-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
lib: fix typo in util.js comment #61365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kimtaejin3
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
kimtaejin3:fix-typo-explicitly-in-util-js
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo: 'explictly' -> 'explicitly' in getCallSites function comment
Ayase-252
approved these changes
Jan 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61365 +/- ##
==========================================
+ Coverage 88.51% 88.52% +0.01%
==========================================
Files 704 704
Lines 208739 208739
Branches 40274 40279 +5
==========================================
+ Hits 184770 184796 +26
+ Misses 15968 15934 -34
- Partials 8001 8009 +8
🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Jan 13, 2026
lpinca
approved these changes
Jan 13, 2026
cjihrig
approved these changes
Jan 14, 2026
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61365 ✔ Done loading data for nodejs/node/pull/61365 ----------------------------------- PR info ------------------------------------ Title lib: fix typo in util.js comment (#61365) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch kimtaejin3:fix-typo-explicitly-in-util-js -> nodejs:main Labels util, author ready Commits 1 - lib: fix typo in util.js comment Committers 1 - Taejin Kim <rlaxowls1316@naver.com> PR-URL: https://github.com/nodejs/node/pull/61365 Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61365 Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 13 Jan 2026 10:36:43 GMT ✔ Approvals: 4 ✔ - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/61365#pullrequestreview-3655232402 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/61365#pullrequestreview-3656132455 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61365#pullrequestreview-3657947996 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61365#pullrequestreview-3660576533 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/21028397396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
util
Issues and PRs related to the built-in util module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'explictly' -> 'explicitly' in getCallSites function comment