-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
assert,util: improve comparison performance #61176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
assert,util: improve comparison performance #61176
Conversation
This makes sure that the toStringTag symbol is used, if available instead of calculating the toString() value each time, if not needed (the type checks make a brand check, so there is no need to check the toStringTag, if non is defined on the object).
|
Local benchmark |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61176 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 703 703
Lines 208585 208612 +27
Branches 40225 40240 +15
=======================================
+ Hits 184650 184674 +24
- Misses 15953 15957 +4
+ Partials 7982 7981 -1
🚀 New features to boost your workflow:
|
This is a workaround for errors recreated by error serdes.
|
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1776/ Results |
| } | ||
| } else if (mode === kLoose && | ||
| (isFloat32Array(val1) || isFloat64Array(val1) || isFloat16Array(val1))) { | ||
| (isFloat32Array(val1) || isFloat64Array(val1) || isFloat16Array(val1))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated change (we should probably have the linter enforce one or the other)
| (isFloat32Array(val1) || isFloat64Array(val1) || isFloat16Array(val1))) { | |
| (isFloat32Array(val1) || isFloat64Array(val1) || isFloat16Array(val1))) { |
This makes sure that the toStringTag symbol is used, if available instead of calculating the toString() value each time, if not needed (the type checks make a brand check, so there is no need to check the toStringTag, if non is defined on the object).