src: add args validation method

[arxngr]

Problem:

When fewer than three arguments are passed or if the third argument is not of type Uint32, the program attempts to access invalid memory or cast incorrect types. This leads to undefined behavior, including potential crashes [1] 2385420 IOT instruction (core dumped) node and not clear what does it mean

So I think we need to validate the args first before we do some assertions below. we can also do same thing in another place that doesn't have the validator

ref issue: #56367

[nodejs-github-bot]

Review requested:

• @nodejs/net

[codecov]

Codecov Report

❌ Patch coverage is 78.57143% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.17%. Comparing base (b0c65bb) to head (707c925).
⚠️ Report is 4264 commits behind head on main.

Files with missing lines	Patch %	Lines
src/tcp_wrap.cc	78.57%	6 Missing and 6 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56487      +/-   ##
==========================================
+ Coverage   88.52%   89.17%   +0.65%     
==========================================
  Files         660      662       +2     
  Lines      190900   191683     +783     
  Branches    36628    36890     +262     
==========================================
+ Hits       168995   170940    +1945     
+ Misses      15090    13612    -1478     
- Partials     6815     7131     +316     

Files with missing lines	Coverage Δ
src/tcp_wrap.cc	80.40% <78.57%> (+0.08%)	⬆️

... and 98 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[arxngr]

i made an update here, so i think we should validate here instead of throwing args error

[jasnell]

you have this setting to backlog as an int32 but we use it as port below, cast as a uint32 then converted to an int with port below. Where is the term backlog coming from here? either way, should make this consistent here.

[arxngr]

yep, i think the backlog should be a "port" here, and I think we don't need cast again since

 int port;
  if (!args[2]->Int32Value(env->context()).To(&port)) return;

already casted to int right (?)

and we don't need this anymore
int port = static_cast<int>(args[2].As<Uint32>()->Value());

[arxngr]

new update here

[jazelly]

can you please also add a test?

[jazelly]

can you please remove these unnecessary changes

[arxngr]

I have added a unit test, but the unnecessary changes are clearly a result of the formatter overzealous behavior. as @jasnell said above, I restored the changes to their original state, yet every time I save the file, it reverts to the modified version.

[arxngr]

Hi guys, I need help for re-review my PR here :)

[github-actions]

This pull request has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

[Ethan-Arrowood]

Hello, I'm doing some backlog hygiene on all PRs related to networking and streaming modules. There hasn't been any activity here for quite a while so I'm going to mark it stalled. It will auto-close in ~30 days. This is not a rejection; if you've like to pick it back up, rebase onto latest main and give me a ping.

Thank you!

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.