Conversation
aduh95
approved these changes
Jun 8, 2024
Contributor
aduh95
left a comment
There was a problem hiding this comment.
Can you add a comment explaining why we're doing this? Otherwise there's a chance it gets reverted if this code is ever refactored
Contributor
|
@KhafraDev is this still needed? |
KhafraDev
commented
May 22, 2025
Member
Author
|
I haven't had to use git node wpt recently but I assume the issue is still present |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #813 +/- ##
==========================================
- Coverage 83.02% 80.15% -2.88%
==========================================
Files 37 39 +2
Lines 4213 4635 +422
==========================================
+ Hits 3498 3715 +217
- Misses 715 920 +205 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #810
I have no idea how to add tests for this, but hopefully it's straightforward. This is needed for undici to use
git node wptto pull tests for its runner.