Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
==========================================
- Coverage 80.56% 71.74% -8.83%
==========================================
Files 39 41 +2
Lines 4847 5878 +1031
==========================================
+ Hits 3905 4217 +312
- Misses 942 1661 +719 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aduh95
reviewed
Apr 14, 2026
aduh95
reviewed
Apr 14, 2026
Renegade334
reviewed
Apr 14, 2026
docs/ncu-ci.md
Outdated
|
|
||
| - a numeric pull request id, for example `34127` | ||
| - a pull request URL, for example `https://github.com/nodejs/node/pull/34127` | ||
| - a commit URL for the head commit of the pull request, for example `https://github.com/nodejs/node/pull/34127/commits/<sha>` |
Member
There was a problem hiding this comment.
Is there a straightforward way to disambiguate "commit URL"? To me, a commit URL would ordinarily be /org/repo/commit/abcde...
"pull request commit URL" perhaps?
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.